Skip to content

cmdlib: Use -hda/-hdb instead of virtio-scsi incantations#1288

Merged
openshift-merge-robot merged 1 commit intocoreos:masterfrom
cgwalters:cmdlib-drive-simplify
Mar 26, 2020
Merged

cmdlib: Use -hda/-hdb instead of virtio-scsi incantations#1288
openshift-merge-robot merged 1 commit intocoreos:masterfrom
cgwalters:cmdlib-drive-simplify

Conversation

@cgwalters
Copy link
Member

@cgwalters cgwalters commented Mar 25, 2020

Qemu has convenient shorthand CLI arguments to do what we
want here. We're explicitly not using virtio because supermin
hardcodes /dev/sda sadly.

Prep for changing this code to use kola qemuexec.

cgwalters
cgwalters commented Mar 25, 2020
View reviewed changes
@cgwalters
cmdlib: Use -hda/-hdb instead of virtio-scsi incantations
247e0d0 
Qemu has convenient shorthand CLI arguments to do what we
want here.  We're explicitly not using virtio because supermin
hardcodes `/dev/sda` sadly.

Prep for changing this code to use `kola qemuexec`.
@cgwalters cgwalters force-pushed the cmdlib-drive-simplify branch from 569152c to 247e0d0 Compare March 25, 2020 20:52
@cgwalters cgwalters mentioned this pull request Mar 25, 2020
Merged
@jlebon
Copy link
Member

jlebon commented Mar 26, 2020

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ad728ab into coreos:master Mar 26, 2020
@Prashanth684
Copy link
Contributor

Prashanth684 commented Mar 27, 2020 •
edited
Loading

unfortunately i think these scsi incantations are needed for s390x and ppc64le :(

supermin: waiting another 1024000000 ns for /sys/block/sda/dev to appear
This usually means your kernel doesn't support virtio, or supermin was unable
to load some kernel modules (see module loading messages above).
supermin: waiting another 2048000000 ns for /sys/block/sda/dev to appear
supermin: waiting another 4096000000 ns for /sys/block/sda/dev to appear
supermin: waiting another 8192000000 ns for /sys/block/sda/dev to appear
supermin: waiting another 16384000000 ns for /sys/block/sda/dev to appear
supermin: waiting another 32768000000 ns for /sys/block/sda/dev to appear
supermin: waiting another 65536000000 ns for /sys/block/sda/dev to appear
supermin: waiting another 131072000000 ns for /sys/block/sda/dev to appear
supermin: waiting another 262144000000 ns for /sys/block/sda/dev to appear
supermin: creating /dev/root as block special 18:0
supermin: mounting new root on /root
mount: /root: No such device or address
[  524.788014] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000100
[  524.788080] CPU: 15 PID: 1 Comm: init Not tainted 5.5.11-200.fc31.ppc64le #1
[  524.788142] Call Trace:
[  524.788169] [c00000007d52bc40] [c000000000fbaf84] dump_stack+0xb8/0x104 (unreliable)
[  524.788230] [c00000007d52bc80] [c00000000016a5fc] panic+0x168/0x40c
[  524.788281] [c00000007d52bd10] [c000000000174090] do_exit+0xd50/0xdc0
[  524.788330] [c00000007d52bdd0] [c0000000001741cc] sys_exit_group+0x5c/0x110
[  524.788379] [c00000007d52be20] [c00000000000b278] system_call+0x5c/0x68
+ '[' '!' -f /srv/tmp/rc ']'
+ fatal 'Couldn'\''t find rc file, something went terribly wrong!'
+ echo 'fatal: Couldn'\''t find rc file, something went terribly wrong!'
fatal: Couldn't find rc file, something went terribly wrong!
+ exit 1

cgwalters added a commit to cgwalters/coreos-assembler that referenced this pull request Mar 27, 2020
@cgwalters
Revert "cmdlib: Use -hda/-hdb instead of virtio-scsi incantations"
72e81f8 
This reverts commit ad728ab because
it apparently doesn't work on s390x/ppc64le:
coreos#1288 (comment)
@cgwalters cgwalters mentioned this pull request Mar 27, 2020
Merged
@cgwalters
Copy link
Member Author

cgwalters commented Mar 27, 2020

OK #1292 for now.

openshift-merge-robot pushed a commit that referenced this pull request Mar 27, 2020
@cgwalters @openshift-merge-robot
Revert "cmdlib: Use -hda/-hdb instead of virtio-scsi incantations"
e9e7de7 
This reverts commit ad728ab because
it apparently doesn't work on s390x/ppc64le:
#1288 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LorbusChris LorbusChris Awaiting requested review from LorbusChris

@mike-nguyen mike-nguyen Awaiting requested review from mike-nguyen

Assignees

@jlebon jlebon

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cgwalters @jlebon @openshift-ci-robot @Prashanth684 @openshift-merge-robot